fix(gateway): improve client registration error messages#485
Merged
Conversation
Return Result instead of Option from new_client_by_id so callers get specific error reasons (empty instance_id, empty app_id, or IP pool exhaustion) instead of a generic allocation failure message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_client_by_idto returnResultinstead ofOption, providing specific error messages for each failure caseinstance_id(e.g. whenno_instance_idis set), emptyapp_id, emptypublic_key, and IP pool exhaustion now each return a distinct error messageTest plan
no_instance_id: trueand verify the error message now says "instance_id is empty (no_instance_id is set?)" instead of the generic message.unwrap()which works for bothOptionandResult